Skip to content

Use lower case extension for setting datatype in data discovery #19954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Apr 3, 2025

I thought that I already did this here, but apparently it was something else. So, now for real .. with a test.

When trying to find out what my original change does I found that DatasetMatcherFactory.matches_format and DatasetMatcherFactory.matches_any_format are unused. Should such code be removed?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added area/testing area/database Galaxy's database or data access layer labels Apr 3, 2025
@github-actions github-actions bot added this to the 25.0 milestone Apr 3, 2025
@mvdbeek mvdbeek merged commit 01e3631 into galaxyproject:dev Apr 16, 2025
55 of 59 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@mvdbeek
Copy link
Member

mvdbeek commented Apr 16, 2025

Thanks @bernt-matthias. If you want to refactor things and remove dead code (yep, sure looks unused) I think it's always better to do that in a separate PR.

@bernt-matthias bernt-matthias deleted the ext-lower branch April 16, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer area/testing kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants