Move FormBoolean back to FormElement field in workflow run form

[ahmedhamidawan]

As opposed to on the step header where we moved it to in 47eb5e8.

It could be confusing for the user to figure out that this is in fact a workflow parameter value like the other string, integer etc. values if the boolean toggle is in the header.

Before ◀️

Option	After ➡️
1
2 (current)

Change Yes/No to True/False?

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[dannon]

+1, this was identified as confusing because it's an inconsistent UI pattern -- all values otherwise are inside the container and this felt like it was supposed to be a control structure or some step meta-option when put in the header. I prefer option 2 as shown in the PR.

[guerler]

We typically place help text at the bottom, not the top, as far as I know. If we were to change this, we’d need to update the tool forms as well for consistency—but personally, I don’t think this change is necessary.

[ahmedhamidawan]

What about this? if it has help text, then no (Yes/No) label, if no help text, then it has the label?

BTW, made it so that the tool form remains the same as before. In any case, the appearance of the FormElements are different in props.workflowRun version, because we sort of show the progress of how much the workflow form has been populated etc (with the card styling and borders)

[mvdbeek]

That looks great!

[martenson]

if it has help text, then no (Yes/No) label, if no help text, then it has the label?

removing he help text and relying completely on the shades of color is making this much less accessible

[mvdbeek]

I don't think that's true, we are not removing help text, we always display it. We just don't display the redundant Yes/No toggle label when the option has help text.
The toggle itself is accessible, here's what VoiceOver sees. It also says whether the toggle is ticked or unticked.

[dannon]

@mvdbeek Out of curiosity, what does it say when you operate it?