-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Migrate Page editing controller endpoint to API #19923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
Mar 28, 2025
mvdbeek
reviewed
Mar 28, 2025
davelopez
reviewed
Mar 28, 2025
Co-authored-by: David López <[email protected]>
Failing tests appear to be unrelated. |
mvdbeek
reviewed
Mar 30, 2025
7c6d7ce
to
11698a9
Compare
4 tasks
1d7dc32
to
dfef310
Compare
4 tasks
Thank you @mvdbeek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further reduces the pages controller endpoint by migrating the edit endpoint to the api. The recently introduced client-side page creation form component has been generalized to also handle the edit form inputs.
How to test the changes?
(Select all options that apply)
License