Skip to content

Migrate Page editing controller endpoint to API #19923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Mar 31, 2025

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Mar 27, 2025

This PR further reduces the pages controller endpoint by migrating the edit endpoint to the api. The recently introduced client-side page creation form component has been generalized to also handle the edit form inputs.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes area/API labels Mar 27, 2025
@guerler guerler added this to the 25.0 milestone Mar 27, 2025
@guerler guerler marked this pull request as ready for review March 27, 2025 22:03
@guerler guerler requested a review from davelopez March 28, 2025 00:52
@guerler
Copy link
Contributor Author

guerler commented Mar 30, 2025

Failing tests appear to be unrelated.

@guerler guerler force-pushed the reduce_page_controller branch from 7c6d7ce to 11698a9 Compare March 30, 2025 10:49
@guerler guerler force-pushed the reduce_page_controller branch from 1d7dc32 to dfef310 Compare March 31, 2025 09:29
@mvdbeek mvdbeek merged commit 5024847 into galaxyproject:dev Mar 31, 2025
55 of 58 checks passed
@guerler guerler deleted the reduce_page_controller branch March 31, 2025 15:41
@guerler
Copy link
Contributor Author

guerler commented Mar 31, 2025

Thank you @mvdbeek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants