-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add better WorkflowSummary
type
#19779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better WorkflowSummary
type
#19779
Conversation
@davelopez Does what I have done here make sense? |
Yes, it does to me :) |
xref #19681 |
@jmchilton I think this takes care of what #19681 reports then 🤔 ? |
I had forgotten that we have fastapi endpoints without defined models. This is fine then. |
We don't have types in the first place so this is all moot.
Thanks @ahmedhamidawan! |
Related to #19777 (?)
Follows up on #19294 (comment)
Fixes #19681
Creates a
WorkflowSummary
type which we use in cases whereStoredWorkflowDetailed
is not needed (or is rather not the actual return from the backend in fact).Then also adds the
AnyWorkflow
type to generalize usage:Moves methods from
workflows.services
to theclient/src/api/workflows.ts
fileI moved some functions that have a typed response from
workflows.services
toworkflows.ts
to make it more uniform with what we do in other places (e.g.:datasets.ts
).How to test the changes?
(Select all options that apply)
License