Fix Tours and add tooltips to history items #19734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
reviewed
Mar 3, 2025
There was a problem hiding this comment.
This test failure seems relevant:
https://github.com/galaxyproject/galaxy/actions/runs/13622274391/job/38074034478?pr=19734
Otherwise it looks good 👍
guerler
force-pushed
the
add_tooltips_to_history_items
branch
from
c3c1ce4 to
caf7fd5
Compare
guerler
changed the title
|
@davelopez thank you for looking into this. I fixed it with: https://github.com/galaxyproject/galaxy/pull/19734/files#diff-3bb7ccd26b62625be7fcac419453678fca11dc586ef06ff3108c9b0eadd7d37cR2265. |
davelopez
approved these changes
Mar 6, 2025
itisAliRH
approved these changes
Mar 6, 2025
|
Thank you for the review, and yes, maybe we should back port it since Tours do not work properly on main rn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with tours that currently do not work properly. Specifically, the upload modal was not displaying during tours. This has been resolved by adjusting the activity bar click target. Additionally, error handling has been improved, and target element visibility is now validated.
This PR also updates the tour requirements modal. Instead of displaying an error message, the modal now provides options to either cancel or create a new history. Requirement conditions have been adjusted to prevent flickering at tour start. Finally, the tours have been modified to ensure the final step remains visible.
This PR also adds tool tips to history items.
How to test the changes?
(Select all options that apply)
License