Skip to content

Remove unused(?) data_dialog form element type. #19669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

jmchilton
Copy link
Member

I was looking at a typing error and I decided the code just wouldn't work as is and I tried to find how it was used and I could not find anything. I'm guessing it is code that has been replaced with an alternative implementation strategy. Anybody know?

After these changes both of these greps are empty.

grep -r data_dialog client/src
grep -r data_dialog lib

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton added kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes area/client labels Feb 20, 2025
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look unused indeed 👍

@jmchilton jmchilton marked this pull request as ready for review February 21, 2025 15:30
@github-actions github-actions bot added this to the 25.0 milestone Feb 21, 2025
@jmchilton jmchilton merged commit f81a01a into galaxyproject:dev Feb 21, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants