Skip to content

Retrieve authentification also for long urls #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2016
Merged

Retrieve authentification also for long urls #1912

merged 1 commit into from
Mar 16, 2016

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 11, 2016

This should make external auth work for requests that do not target the URL root [untested!], and it does prevent

Invalid url 'https://toolshed.g2.bx.psu.edu/api/repositories' received by tool shed registry's password_manager_for_url method.

for @davebx PR #1392.

@jmchilton
Copy link
Member

👍

@martenson martenson added this to the 16.04 milestone Mar 12, 2016
martenson added a commit that referenced this pull request Mar 16, 2016
@martenson
Merge pull request #1912 from mvdbeek/relax_password_manager_matching
aae2006 
Retrieve authentification also for long urls
@martenson martenson merged commit aae2006 into galaxyproject:dev Mar 16, 2016
@davebx
Copy link
Contributor

davebx commented Mar 16, 2016

Thanks, @mvdbeek

@mvdbeek mvdbeek deleted the relax_password_manager_matching branch April 8, 2016 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/toolshed kind/enhancement
Projects
None yet
Milestone
16.04
Development

Successfully merging this pull request may close these issues.
4 participants
@mvdbeek @jmchilton @davebx @martenson