-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Cherry-picked changes from pull request #1392. #1821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@web.expose_api_anonymous | ||
def get_installable_revisions( self, trans, **kwd ): | ||
""" | ||
GET /api/repositories/get_unordered_installable_revisions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/unordered_//
Also few lines below.
thanks for splitting this up @davebx ! makes it much easier to review |
👍 |
Cherry-picked changes from pull request #1392.
response_dict[ 'status' ] = 'ok' | ||
response_dict[ 'message' ] = 'Entries for repository %s owned by %s have been added to the Tool Shed repository registry.' \ | ||
% ( name, owner ) | ||
return response_dict | ||
|
||
@web.expose_api_anonymous | ||
def get_ordered_installable_revisions( self, trans, name, owner, **kwd ): | ||
def get_ordered_installable_revisions( self, trans, **kwd ): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davebx this signature change is not reflected in the documentation and maybe breaks backward compatibility (i.e. in bioblend)
reported in http://dev.list.galaxyproject.org/Test-tool-shed-api-repositories-get-ordered-installable-revisions-not-working-td4669149.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davebx you can also test this with the ansible-tools role https://github.com/galaxyproject/ansible-galaxy-tools
It is not possible to install tools from the TTS anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created an issue for it: #1940
This PR was merged without a milestone attached. |
This should pull in all the toolshed-specific changes from #1392