Skip to content

Add install_resolver_dependencies keyword to install_repository_revision #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jul 30, 2016

This goes together with galaxyproject/galaxy#2554.
On older galaxy instances install_resolver_dependencies will be silently ignored.
Is that okay or should we explicitly check the galaxy version?
ping @nsoranzo

@@ -105,6 +109,10 @@ def install_repository_revision(self, tool_shed_url, name, owner,
(see http://wiki.galaxyproject.org/DefiningRepositoryDependencies
for more details)

:type install_resolver_dependencies: bool
:param install_resolver_dependencies: Whether or not to automatically
install resolver dependencies (e.g. conda)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter is silently ignored in Galaxy ``release_2016.04`` and earlier.

@nsoranzo
Copy link
Member

nsoranzo commented Aug 1, 2016

@mvdbeek Thanks for the PR! I think that documenting it as in my inline comment should be enough.

@nsoranzo
Copy link
Member

nsoranzo commented Aug 1, 2016

@mvdbeek Just to be sure before I merge: install_tool_dependencies, install_repository_dependencies and install_resolver_dependencies can all be True at the same time?

@mvdbeek
Copy link
Member Author

mvdbeek commented Aug 1, 2016

Yes, there is no problem setting any combination of these.

@nsoranzo
Copy link
Member

nsoranzo commented Aug 1, 2016

Cool, thanks!

@nsoranzo nsoranzo merged commit fda9813 into galaxyproject:master Aug 1, 2016
@mvdbeek mvdbeek mentioned this pull request Aug 9, 2016
afgane added a commit that referenced this pull request Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants