-
Notifications
You must be signed in to change notification settings - Fork 29
TES 0.4.0 Release #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TES 0.4.0 Release #118
Conversation
* removed any `title: OPTIONAL` annotations that did not make sense * added `required: []` for required parameters * Added schema version, updating minor version since prefix may be a API breaking change Signed-off-by: Angel Pizarro <[email protected]>
Removed `creation_time` from the required list for `tesTask` as it's marked as `readOnly` as per @adamstruck's [comment](#114 (review)).
…-params Removed protobuf-to-swagger conversion artifacts
Susheel and Angel think this will be sufficient for the April meeting. |
@susheel @delagoya @briandoconnor Hi guys, are you still planning on merging this with master? |
LGTM |
+1 Also LGTM |
There are merge conflicts though. @denis-yuen do you think these changes should be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a general cleanup of the artifacts from converting from Protobuf a while back. I think that all of it is not controversial but will defer to an implementer to say that these changes to do not cause unexpected behavior, since I did move from documented requirements on the spec to swagger's formal mechanism on defining constraints (e.g. OUTPUT ONLY
--> readOnly: true
)
@delagoya looks like git was just confused because Assuming |
LGTM |
Task Execution Service 0.4.0 Release
Summary:
task_execution.swagger.json
into OAPI 2.0 YAMLrequired
andoptional
fields for OAPI request/response schemaBreaking Changes:
task_schema.swagger.json
updated toopenapi/task_schema.swagger.yaml
required
fields are now explicit in the schema.