Skip to content

TES 0.4.0 Release #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2019
Merged

TES 0.4.0 Release #118

merged 4 commits into from
Sep 20, 2019

Conversation

susheel
Copy link
Member

@susheel susheel commented Mar 7, 2019

Task Execution Service 0.4.0 Release

Summary:

  • Conversion of task_execution.swagger.json into OAPI 2.0 YAML
  • Cleanup of required and optional fields for OAPI request/response schema

Breaking Changes:

  • Schema location task_schema.swagger.json updated to openapi/task_schema.swagger.yaml
  • required fields are now explicit in the schema.

delagoya and others added 3 commits February 22, 2019 19:44
* removed any `title: OPTIONAL` annotations that did not make sense
* added `required: []` for required parameters
* Added schema version, updating minor version since prefix may be a API breaking change

Signed-off-by: Angel Pizarro <[email protected]>
Removed `creation_time` from the required list for `tesTask` as it's marked as `readOnly` as per @adamstruck's [comment](#114 (review)).
…-params

Removed protobuf-to-swagger conversion artifacts
@briandoconnor
Copy link
Contributor

Susheel and Angel think this will be sufficient for the April meeting.

@MattMcL4475
Copy link
Contributor

@susheel @delagoya @briandoconnor Hi guys, are you still planning on merging this with master?

@susheel susheel requested a review from delagoya September 18, 2019 07:18
@susheel
Copy link
Member Author

susheel commented Sep 18, 2019

LGTM

@delagoya
Copy link
Collaborator

+1

Also LGTM

@delagoya
Copy link
Collaborator

There are merge conflicts though. @denis-yuen do you think these changes should be merged?

@delagoya delagoya assigned delagoya and denis-yuen and unassigned delagoya Sep 19, 2019
Copy link
Collaborator

@delagoya delagoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a general cleanup of the artifacts from converting from Protobuf a while back. I think that all of it is not controversial but will defer to an implementer to say that these changes to do not cause unexpected behavior, since I did move from documented requirements on the spec to swagger's formal mechanism on defining constraints (e.g. OUTPUT ONLY --> readOnly: true)

@denis-yuen
Copy link
Member

@delagoya looks like git was just confused because task_schema.swagger.json was deleted and reverted previously in master.

Assuming openapi/task_schema.swagger.yaml is correct, this LGTM

@denis-yuen denis-yuen assigned delagoya and unassigned denis-yuen Sep 19, 2019
@adamstruck
Copy link
Member

LGTM

@susheel susheel merged commit 61e32f3 into master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants