feat: open external links in a new window #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-theme-dream-docs-preview canceled.
|
Closed
|
Hi, @hst1189, thanks for reporting this problem. I agree with your solution, but I also update some of the code to detect absolute URLs using urls.Parse because I often see this method in Hugo's documentation. If you agree with these changes, I'll merge this PR after you reply. BTW, I saw that your site content is mainly in Japanese, so I decided to reply you in English 😃, and your site background is very beautiful 👍🏼. |
|
@g1eny0ung |
|
好的，那我就合并这个PR了。感谢使用～ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
感谢作者提供的 Hugo Theme Dream
在利用模板制作网站的过程中，遇到了跳转问题
为了实现站外跳转，本PR 对跳转问题做了修改
markdown存在默认情况下， 存在无法跳转新页面的缺陷
添加一个render-link.html，实现 同域名时自页面跳转，不同域名时新页面跳转的功能
試作品：https://myfont.us.kg/