Add WhatsApp to share.html #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-theme-dream-docs-preview canceled.
|
g1eny0ung
requested changes
Sep 12, 2024
layouts/partials/share.html
Outdated
| @@ -1,8 +1,16 @@ | |||
| <span class="flex items-center gap-2"> | |||
| <span class="text-sm font-medium">Share on:</span> | |||
There was a problem hiding this comment.
I'm unwilling to add the text "share on" before icons because extra work is needed to adapt to other languages. And also it's a matter of personal preference, I guess adding a slot there is a better solution so that you can insert anything into it.
There was a problem hiding this comment.
@diamantelist In d703a80, I've added a slot named post-share-left. Now you can create a post-share-left.html file in layouts/partials/ of your project, and then add this line to it.
I haven't figured out if I need to add the text here, but I think it should also be free for the user to choose. So I added a slot to help implement.
g1eny0ung
approved these changes
Sep 14, 2024
g1eny0ung
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.