-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
add Library Scan (with image scan) #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a6777dc
to
652a74c
Compare
gopkg.in/mattn/go-runewidth.v0 v0.0.4 // indirect | ||
) | ||
|
||
replace github.com/genuinetools/reg => github.com/tomoyamachi/reg v0.16.2-0.20190418055600-c6010b917a55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I got here from golang/go#32879. We're not sure whether this version string should/will be valid in Go 1.13, since it refers to the same commit as v0.16.1
.
Could you share some info on how you produced this version string? I'm curious as to how you arrived at a pseudo-version instead of the tagged version.
CC @jayconrod @heschik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcmills That was an odd way.
git checkout -b <branch>
- fixed in a forked repository
git tag v0.16.2 && git push origin <branch> --tags
- add
replace github.com/genuinetools/reg => github.com/tomoyamachi/reg v0.16.2
to go.mod, and rungo mod tidy
- something wrong in step 4
git tag -d v0.16.2 && git push --tags
- add
replace github.com/genuinetools/reg => github.com/tomoyamachi/reg <branch>
to go.mod, and rungo mod tidy
- auto generate
v0.16.2-0.20190418055600-c6010b917a55
go version go1.12.3 darwin/amd64
I hope this answer helps you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I will fix the current versioning.
What did you implement:
add library scan via trivy.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
test on the following config file.
Checklist:
You don't have to satisfy all of the following.
make fmt
make test