fix(oval): add pseudo server type in NewOVALClient #2254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.
What did you implement:
Fixes #2253
In this commit, ServerTypePseudo was removed from NewOVALClient:
9c8fd04#diff-c38ba8400657a4caf68a8813319549c02e254e9ccb12099f6d3dba39bbf81ddeL688-L689
As a result, an error occurred when opening the database before starting the server, because the family used at that time was ServerTypePseudo:
28e3ff5#diff-ba4491525d7251d0ed3fa7f42df81f3150fa73551b7b4923bd45b14bd283e299R274
Therefore, this PR adds ServerTypePseudo back to NewOVALClient.
Note that this error does not occur during reporting because pseudo servers skip OVAL processing:
vuls/detector/detector.go
Lines 380 to 382 in c40e7e8
Type of change
How Has This Been Tested?
before
after
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES
Reference