-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore(ci): update dependabot.yml to group dependencies #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refines Dependabot settings by grouping updates for GitHub Actions and Go modules, and scheduling Go module updates on a custom cron.
- Adds an “all” group for the first ecosystem (likely GitHub Actions) to bundle every update
- Switches Go module updates from a monthly interval to a custom cron for 1st and 3rd Mondays and excludes Trivy
Comments suppressed due to low confidence (1)
.github/dependabot.yml:26
- Dependabot does not recognize the 'cronjob' key; it should be 'cron' to define a custom schedule as per the Dependabot configuration schema.
cronjob: "0 0 1-7,15-21 * 1" # on 0 AM at 1st and 3rd Mondays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the Dependabot configuration to batch related updates and apply a bi-weekly schedule for Go modules.
- Consolidates all GitHub Actions updates into a single “all” group
- Adds an “all-but-trivy” group for Go modules and switches its schedule to a cron expression
- Keeps Docker updates on a monthly cadence
Comments suppressed due to low confidence (2)
.github/dependabot.yml:25
- Dependabot only accepts 'daily', 'weekly', or 'monthly' for the 'interval' key. Remove this line and rely solely on the 'cron' schedule key.
interval: "cron"
.github/dependabot.yml:26
- The correct schedule key is 'cron', not 'cronjob'. Rename this key to 'cron' so Dependabot recognizes the expression.
cronjob: "0 0 1-7,15-21 * 1" # on 0 AM at 1st and 3rd Mondays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about three groups: vuls, trivy, and others?
vuls group
- github.com/MaineK00n/vuls-data-update
- github.com/MaineK00n/vuls2
- github.com/vulsio/go-cti
- github.com/vulsio/go-cve-dictionary
- github.com/vulsio/go-exploitdb
- github.com/vulsio/go-kev
- github.com/vulsio/go-msfdb
- github.com/vulsio/gost
- github.com/vulsio/goval-dictionary
trivy group
- github.com/aquasecurity/trivy
- github.com/aquasecurity/trivy-db
- github.com/aquasecurity/trivy-java-db
others group
6f52537
to
d4a9f6c
Compare
d4a9f6c
to
19b4823
Compare
Feels great! Pushed! |
What did you implement:
There is no "bi-weekly" value for the "interval" key, this PR uses the "cron" value and "cronjob" key for specifying schedule.
"cron" value and "cronjob" key are described in https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#cronjob
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
NONE, hope this work after merge
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Reference