fix(cmd/saas): add timeout option #2183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.
What did you implement:
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Added timeout option to the vuls-saas command.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
To reproduce an environment where communication times out, a mock server was set up to delay the response.
Changed URL in config.toml to that of the mock server.
Executed vuls saas command with timeout option
The timeout is set to 5 seconds because the response from the mock server comes back after a 10-second delay.
Errors are output correctly when the context times out.
The timeout is set to 15 seconds
The mock server response is returned before the timeout, and the expected error is output.
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES
Reference