-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(report): Refactor SBOM generation: split functions, improve PURL logic, set OS as root #2171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MaineK00n
merged 12 commits into
future-architect:master
from
kl-sinclair:sbom-cdx-fix-and-refac
Apr 11, 2025
Merged
fix(report): Refactor SBOM generation: split functions, improve PURL logic, set OS as root #2171
MaineK00n
merged 12 commits into
future-architect:master
from
kl-sinclair:sbom-cdx-fix-and-refac
Apr 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaineK00n
reviewed
Apr 9, 2025
MaineK00n
reviewed
Apr 9, 2025
MaineK00n
reviewed
Apr 9, 2025
Co-authored-by: MaineK00n <[email protected]>
Co-authored-by: MaineK00n <[email protected]>
MaineK00n
reviewed
Apr 9, 2025
MaineK00n
reviewed
Apr 10, 2025
MaineK00n
reviewed
Apr 10, 2025
MaineK00n
reviewed
Apr 10, 2025
MaineK00n
previously approved these changes
Apr 11, 2025
MaineK00n
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
We have refactored and improved the CycloneDX SBOM generation functionality as follows:
GenerateCycloneDX
function intoToCycloneDX
, which converts aScanResult
to a CycloneDX BOM, andSerializeCycloneDX
, which serializes the BOM into a byte array.These changes enhance the maintainability and extensibility of the codebase by modularizing the SBOM generation process and improving the handling of Package URLs.
Type of change
How Has This Been Tested?
before
after
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES