Skip to content

Update README.md and example-config.toml to be more accurate #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update README.md and example-config.toml to be more accurate #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe14a2c
Update README.md
randito78 Oct 6, 2021
c5f20cb
Update example-config.toml StartTime
randito78 Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ SQL recipes for Data Export analysis are in the [Data Export Cookbook](https://g
1. Download the latest [release binary](https://github.com/fullstorydev/hauser/releases)
2. Download the included `example-config.toml` file and customize it for your environment,
including your FullStory API key, warehouse host, and credentials. AWS credentials (for S3) come from your local environment.
Your FullStory API key needs to have either the "Architect", or "Admin" permission level to create exports.
3. Assuming the binary and updated config are in the current directory, run:
```bash
./hauser -c myconfig.toml
Expand Down
4 changes: 1 addition & 3 deletions example-config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ ExportDuration = "6h"
ExportDelay = "24h"

# StartTime determines how far back to start exporting data if starting fresh.
# This should be an timestamp like with the followin format: 2018-12-27T18:30:00Z.
# If start time is empty, this will default to 30 days in the past.
StartTime = ""
StartTime = <Start time for data exports in the following format: 2018-12-27T18:30:00Z>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using a value that is definitely not parseable, I would prefer that we use the "zero" time value for go

Suggested change
StartTime = <Start time for data exports in the following format: 2018-12-27T18:30:00Z>
# If not set or left as the zero time, this will default to 30 days in the past.
# StartTime = "0001-01-01T00:00:00Z"


# Valid provider values:
# * local: Used for downloading files to the local machine.
Expand Down