Fix section related bugs #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… related to dep & msdd epic Fixed a) Delete button shown for dependent fields within sections b) Max limit is not adhered to within sections c) Show dependent field related error message instead of default fields error BREAKING CHANGE: The logic for computing the count within sections is revised
Bharatram-Santhanakrishnan
requested review from
rihansiddhi and
prasanna-vijayan
rihansiddhi
approved these changes
Apr 3, 2025
prasanna-vijayan
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Change log
supportDependentAndMSDDInSections- A new property has been introduced to let users decide whether sectional fields should accept dependent and multiselect dropdown fields. This is to make the section more flexible and at the same time reduce the blast radius in case something goes wrong.This flag only controls whether the fields are allowed to dropped in a section or not. It does not govern the below mentioned logic.
error elementas well into calculation thus returning one more than the actual count. This logic held good earlier since all the fields had a count of 1. Now that dependent fields are counted as 3, we needed to check what the draggedElement was and its count.How Has This Been Tested?
Dev testing has been done by checking the max limit breach for different field types. Checked reordering as well to ensure that the element belonging to the same container does not contribute to the count.