1687-Polkadot v1.1.0 Upgrade follow up for small issues found in final review #1752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
metadata-changed
mattheworris
force-pushed
the
1687-follow-up
branch
from
0928d1c to
98b7bc6
Compare
github-actions
bot
removed
the
metadata-changed
Codecov Report
@@ Coverage Diff @@
## main #1752 +/- ##
==========================================
- Coverage 88.07% 88.05% -0.03%
==========================================
Files 50 50
Lines 4243 4243
==========================================
- Hits 3737 3736 -1
- Misses 506 507 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mattheworris
changed the title
mattheworris
force-pushed
the
1687-follow-up
branch
from
7a31b47 to
94490ff
Compare
shannonwells
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is clean up a few issues from the polkadot v1.1.0 upgrade.
Discussion
RUSTSEC-2022-0093from.cargo-deny.toml.w3fto[sources.allow-org]to eliminate some warnings.substrate-wasm-builderfrom[build-dependencies]inruntime/common/Cargo.tomlChecklist