Closed
Description
To aid in debugging the custom updater logic, let's add more informative logging when errors are encountered. We currently log that an error occurred during VM start or stop, e.g.
securedrop-workstation/launcher/sdw_updater_gui/Updater.py
Lines 449 to 453 in f2afb12
but not what the specific error was. We'd need to catch stderr and log that, as well. Since we're still using subprocess to shell out, we'll have to use PIPE for stderr, otherwise the "stderr" attribute on the exception will be empty.
We also have a request for explicit logging of xl list
before the start actions #498 (comment), which sounds like a great idea. Non-decoded bytestrings should be logged to ensure that newlines aren't interpreted.
Metadata
Metadata
Assignees
Labels
No labels