This repository was archived by the owner on Oct 21, 2020. It is now read-only.
Just jesting #68
Closed
Just jesting #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* staging: feat(createuser): add validation and error handling to createuser feat(tools): add async error handling helper chore(tools): ignore snyk warn of http-proxy-agent feat(tools): no more global installs/exports chore: temporarily ignore hoek for 30 days (freeCodeCamp#53)
* origin/staging: chore: lint (freeCodeCamp#63) feat(tools): add nodemon to auto-restart on file changes chore(dependencies): update lockfile and package formatting
|
Don't mind me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently is mostly scaffolding: it hooks up Jest, and sets up a config that spins up a MongoDB server in memory -according to docs that should take about 7MB or RAM and runs tests against it. Saves us from wiring up Docker and configuring services in Travis.
There is an issue with running these tests in parallel, see jestjs/jest#5731 for now we can run tests serially, which is the recommended mode for CI anyway 🤷♂️ .
The only test I've added for now is test/user.test.js, which creates a user using mongoose, and tests if it can retrieve it using graphql. As that endpoint has 2 PRs open and I don't want to get in their way, I won't try to get this merged yet. However, I'd love for us to start having a healthy culture of tests in place sooner rather than later 😺
@Bouncey, @raisedadead I've added you as reviewers but mind the WiP label, it's there for a reason .