Skip to content

feat: handle linked docs while deleting #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

feat: handle linked docs while deleting #846

wants to merge 7 commits into from

Conversation

pratikb64
Copy link
Collaborator

@pratikb64 pratikb64 commented May 22, 2025 •
edited by shariquerik
Loading

fixes: #230

@pratikb64 pratikb64 marked this pull request as ready for review May 22, 2025 07:32
@pratikb64 pratikb64 requested a review from shariquerik May 22, 2025 07:32
@michellealva
Copy link
Collaborator

michellealva commented May 22, 2025 •
edited
Loading

@pratikb64 found the following issues:

  • Add back button here
    IMAGE 2025-05-22 16:37:25

  • View should take me to portal view and not desk view
    IMAGE 2025-05-22 16:35:10

  • Should not force the user to compulsorily unlink.. give select option to select records that user wants to delete and rest can be unlinked.

  • Font size of dialog looks huge

shariquerik
shariquerik requested changes Jun 11, 2025
View reviewed changes
crm/api/doc.py


@frappe.whitelist()
def getLinkedDocs(doctype, docname):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never use camelCase in python code only use snake_case and in js use camelCase not snake_case

frontend/components.d.ts
@@ -53,6 +54,7 @@ declare module 'vue' {
ContactsIcon: typeof import('./src/components/Icons/ContactsIcon.vue')['default']
ContactsListView: typeof import('./src/components/ListViews/ContactsListView.vue')['default']
ConvertIcon: typeof import('./src/components/Icons/ConvertIcon.vue')['default']
copy: typeof import('./src/components/DeleteLinkedDocModal copy.vue')['default']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

frontend/src/components/ListViews/LinkedDocsListView.vue
page = 'contacts'
id = doc.reference_docname
break
case 'Organization':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is CRM Organization not Organization

@shariquerik
Copy link
Member

@pratikb64 Don't show CRM Lead, CRM Deal, CRM Task etc on UI strip CRM only show Lead, Deal, Task etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shariquerik shariquerik shariquerik requested changes

Assignees
No one assigned
Labels
backport main-hotfix
Projects
None yet
Milestone
No milestone
3 participants
@pratikb64 @michellealva @shariquerik