Skip to content

Refactored nodes, added categories, Implemented FloatPrimitive #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ScrewTSW
Copy link

  • Refactored nodes
  • Set subcategories for each node type
  • Implemented new FloatPrimitive - the default PrimitiveNode had very broken behavior when it comes to value piping and precision

CAUTION:

  • .nodes.ToString.RF_ToString has major issues - unusable
    The node can be piped to and from
    Upon execution the node fails with following error:
Failed to validate prompt for output 57:
* RF_ToString 91:
  - Return type mismatch between linked nodes: value, FLOAT != INT,BOOL,FLOAT,NUMBER

I tried multiple format inputs based on ComfyUI Code, still get parsing errors:
type array of strings:

Failed to validate prompt for output 9:
* RF_ToString 91:
  - Return type mismatch between linked nodes: value, FLOAT != ['BOOL', 'INT', 'FLOAT', 'NUMBER']

type string "*"

Failed to validate prompt for output 57:
* RF_ToString 91:
  - Return type mismatch between linked nodes: value, FLOAT != *

…UI, can be piped, throws error upon render

Signed-off-by: Tibor Dancs <[email protected]>
Signed-off-by: Tibor Dancs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants