CLI: accept RFC3339-formatted dates in relevant arguments #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-rms
force-pushed
the
james/fg-9191-mcap-cli-accept-iso-8601-timestamps-for-filter-args
branch
from
20552cd to
11e3094
Compare
go/cli/mcap/cmd/filter.go
Outdated
| @@ -416,6 +441,18 @@ usage: | |||
| 0, | |||
| "messages with log times before nanosecond-precision timestamp will be included.", | |||
| ) | |||
| startDate := filterCmd.PersistentFlags().String( | |||
| "start-date", | |||
There was a problem hiding this comment.
nit start-datetime? Since it is both a date and time? Probably I'd even say that start is sufficient and can accept the start string as RFC3339 or the nanosecond variant. Not "real" reason that the program can't figure it out between those two formatss
There was a problem hiding this comment.
should start and start-secs accept an RFC3339 formatted timestamp in that world?
There was a problem hiding this comment.
start-secs I'd have a harder time making an argument for given it says "secs". start seems to be asking for flexible support input formats
sofuture
reviewed
Nov 1, 2024
| @@ -187,11 +195,19 @@ func init() { | |||
| addAttachmentCmd.PersistentFlags().StringVarP( | |||
| &addAttachmentMediaType, "content-type", "", "application/octet-stream", "content type of attachment", | |||
| ) | |||
| addAttachmentCmd.PersistentFlags().Uint64VarP( | |||
| &addAttachmentLogTime, "log-time", "", 0, "attachment log time in nanoseconds (defaults to current timestamp)", | |||
| addAttachmentCmd.PersistentFlags().StringVarP( | |||
There was a problem hiding this comment.
Nit: I think these are fine on a single line and easier to read
sofuture
approved these changes
Nov 1, 2024
james-rms
commented
Nov 3, 2024
james-rms
deleted the
james/fg-9191-mcap-cli-accept-iso-8601-timestamps-for-filter-args
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Added
CLI:
mcap add attachmentaccepts RFC3339-formatted dates to specify the log and creation times for the new attachment.CLI:
mcap filteraccepts RFC3339-formatted dates for start and end times.Docs
None.
Description
Adds the ability for users to specify a date when filtering MCAP files, or adding attachments.
I did a quick pass to see if there are any other arguments where we accept a date or date-like value, I can't see any more.