Add message components #3393
Open
Add message components #3393
+124
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…net-foundry into 3022-2-message-components
…net-foundry into 3022-2-message-components
…net-foundry into 3022-2-message-components
…net-foundry into 3022-2-message-components
…net-foundry into 3022-2-message-components
…net-foundry into 3022-2-message-components
franciszekjob
requested review from
cptartur,
kkawula and
ksew1
and removed request for
a team
cptartur
reviewed
May 23, 2025
…net-foundry into 3022-2-message-components
…net-foundry into 3022-2-message-components
cptartur
approved these changes
May 26, 2025
This was referenced May 26, 2025
kkawula
reviewed
May 27, 2025
ksew1
reviewed
May 27, 2025
| @@ -64,4 +66,14 @@ impl UI { | |||
| OutputFormat::Json => eprintln!("{}", message.json()), | |||
| } | |||
| } | |||
|
|
|||
| /// Print a warning message to stdout using the configured output format. | |||
| pub fn print_warning(&self, text: &str) { | |||
There was a problem hiding this comment.
This is inconsistent with signature print
pub fn print<T>(&self, message: &T)
where
T: Message + serde::Serialize,
ksew1
reviewed
May 27, 2025
| #[derive(Serialize)] | ||
| pub struct TaggedMessage<'a> { | ||
| tag: &'a str, | ||
| text: &'a str, |
There was a problem hiding this comment.
Shouldn't it be &T where T: Message?
There was a problem hiding this comment.
So we can allow creating Labeled/Tagged message from normal Message? Probably makes sense.
cptartur
reviewed
May 27, 2025
| #[derive(Serialize)] | ||
| pub struct TaggedMessage<'a> { | ||
| tag: &'a str, | ||
| text: &'a str, |
There was a problem hiding this comment.
So we can allow creating Labeled/Tagged message from normal Message? Probably makes sense.
| } | ||
| } | ||
|
|
||
| impl Message for TaggedMessage<'_> { |
There was a problem hiding this comment.
…net-foundry into 3022-2-message-components
…y-rs/starknet-foundry into 3022-2-message-components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3022
Stack:
docscrate #3409shared#3405Introduced changes
Add
TypedMessageandLabeledMessagecomponents to foundry-uiChecklist
CHANGELOG.md