Skip to content

Migrate to new macro syntax #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Migrate to new macro syntax #3068

wants to merge 5 commits into from

Conversation

ddoktorski
Copy link
Contributor

Closes #2858

Introduced changes

  • In short:
    • String -> TokenStream
    • format!/formatdoc! -> quote!
    • dyn SyntaxGroup -> SimpleParserDatabase

Note: Tested locally with Scarb built from the dev branch.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@ddoktorski ddoktorski force-pushed the 2858-new-macro-syntax branch from 41c9323 to cbd1fe9 Compare March 27, 2025 13:33
Copy link

Hi! This pull request hasn't had any activity for a while, so I am
marking it as stale. It will close in 14
days if it is not updated. Thanks for contributing!

@github-actions github-actions bot added the stale Stale Bot label Apr 28, 2025
@ddoktorski ddoktorski removed the stale Stale Bot label Apr 28, 2025
@ddoktorski ddoktorski force-pushed the 2858-new-macro-syntax branch from cbd1fe9 to 7fa1b17 Compare May 7, 2025 14:59
@ddoktorski ddoktorski force-pushed the 2858-new-macro-syntax branch from 7fa1b17 to 9e29163 Compare May 7, 2025 15:07
@cptartur cptartur force-pushed the 2858-new-macro-syntax branch from 0f61653 to 8e910c3 Compare May 22, 2025 13:54
cptartur added 2 commits May 23, 2025 11:30
# Conflicts:
#	crates/snforge-scarb-plugin/Cargo.lock
#	crates/snforge-scarb-plugin/src/attributes/test.rs
#	crates/snforge-scarb-plugin/tests/integration/multiple_attributes.rs
#	crates/snforge-scarb-plugin/tests/integration/single_attributes/test.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite snforge plugin to new macro syntax
2 participants