Skip to content

Release workflow Bug - invalid artifacts names #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkawula opened this issue May 20, 2025 · 0 comments · Fixed by #3335
Closed

Release workflow Bug - invalid artifacts names #3378

kkawula opened this issue May 20, 2025 · 0 comments · Fixed by #3335
Assignees
@kkawula
Labels
new

Comments

@kkawula
Copy link
Member

kkawula commented May 20, 2025

Current State

After changes in the release workflow, a small mistake came in. In the current state, it isn't possible to download the released package, zipped artifacts have changed name, and now there is a missing v before version. It has to be manually renamed after creating a release to allow downloading a new version with asdf.

Objective

Fix release script

Additional Context

No response
@kkawula kkawula self-assigned this May 20, 2025
@github-actions github-actions bot added the new label May 20, 2025
@kkawula kkawula mentioned this issue May 20, 2025
Merged
5 tasks
@kkawula kkawula moved this from New to TODO in Starknet foundry May 21, 2025
@kkawula kkawula changed the title Release workflow bug Release workflow Bug - invalid artifacts names May 21, 2025
@kkawula kkawula moved this from TODO to In Progress in Starknet foundry May 21, 2025
github-merge-queue bot pushed a commit that referenced this issue May 22, 2025
@kkawula
Fix release workflow (#3335)
588acf5 
<!-- Reference any GitHub issues resolved by this PR -->
Closes #3378

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkawula kkawula

Labels
new
Projects
Starknet foundry
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix release workflow foundry-rs/starknet-foundry
1 participant
@kkawula