feat: added block.time and block.number override in cast #10727
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jun 9, 2025
crates/cast/src/cmd/call.rs
Outdated
Comment on lines
151
to
156
|
|
||
| /// Override the time field of a block | ||
| /// | ||
| /// Format: block:time | ||
| #[arg(long = "override-time", value_name = "BLOCK:TIME")] | ||
| pub time_overrides: Option<Vec<String>>, |
There was a problem hiding this comment.
we can name this just block.time because block overrides arent't that complex, this can be a simple u64
crates/cast/src/cmd/call.rs
Outdated
Comment on lines
440
to
445
| fn time_value_override(input: &str) -> Result<(&str, &str), eyre::Report> { | ||
| let (block_str, time_str) = input.split_once(':').ok_or_else(|| { | ||
| eyre::eyre!("Invalid override `{input}`. Expected format: <block>:<time>") | ||
| })?; | ||
| Ok((block_str, time_str)) | ||
| } |
There was a problem hiding this comment.
this we can change to a single u64 arg on the cli
mattsse
reviewed
Jun 10, 2025
Comment on lines
+381
to
+386
| // Early return if no override set - <https://github.com/foundry-rs/foundry/issues/10705> | ||
| if self.block_time.as_ref().is_none() { | ||
| return Ok(None); | ||
| } | ||
|
|
||
| let block_overrides = BlockOverrides::default(); |
There was a problem hiding this comment.
this works, we'll need to check this for any additional overrides field we will introduce
|
@Soubhik-10 while we're at it, let's also add a block.number override value? |
Sure 🫡 |
Soubhik-10
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6062