Remove incorrect rest in Beethoven/Piano_Sonatas/17-2 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged the previous one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Beethoven/Piano_Sonatas/17-2, there is a rest in staff 1 that should not be there:
This PR simply removes it (as well as the associated
<backup>tag that was used to compensate the shift introduced by this additional rest).Note that this score contains other errors. I might try to fix them at some point, but probably in another PR. They are quite more complex than this one, and are frequent across the whole dataset. It's about the
<divisions>tag not allowing to represent exactly all divisions of the score (like unusual tuplets), resulting in rounding errors in durations, and therefore spurious<forward>tags, as well as invisible rests to compensate for the shift introduced by the rounding.EDIT: As I was studying a lot of scores in parallel, I've just figured out that I've already opened a PR for this score (#16). This PR is about a different issue, and is not compatible with the other one as durations won't match. I can update this one when/if you merge the other one. Or I can directly integrate this change in the other PR if you prefer. I'll pass this PR as draft in the meantime.