Fix LDAP queries with non-ascii chars #1946
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeffIsBack
changed the title
|
@anadrianmanrique @gabrielg5 any chance one of you could take a look at this? It would make the life of Europeans with special chars in their language much easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently querying with non-ascii chars is not possible because of the default encoding
latin-1/iso-8859-1. This prevents queries like the german "Domänen Administratoren" or other non-ascii entities. To fix this, the search_filter'sAssertionValuemusst be encoded withutf-8instead oflatin-1:Take this fix with a grain of salt. This change seems logical to me, but my knowledge about Asn1 is limited.