Skip to content

Hotfix/fix type aliases #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Hotfix/fix type aliases #221

merged 2 commits into from
Feb 14, 2025

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

n/a

Description

Webpack was clobbering the type de-aliasing (tsc-alias) by directly transpiling typescript. Now webpack uses the already transpiled lib directory, and the tsc-alias can do its job unperturbed by a downstream webpack process.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit 2987680 into master Feb 14, 2025
8 checks passed
lane-formio pushed a commit that referenced this pull request Feb 14, 2025
* separate type de-aliasing into a separate build step

* update webpack to NOT use typescript directly, instead using transpiled JS as its entrypoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants