feat(chore): LESS maps instead of css overrides #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json
lubber-de
added a commit
to fomantic/Fomantic-UI
that referenced
this pull request
Sep 30, 2022
This PR moves all icon declarations out of the overrides file and into LESS maps, so the icon selectors are not hardcoded anymore but rendered at compile time. This now offers easy adjustment of (un)-wanted icons by simpy adjusting the related @icon-map maplist in a possible custom themes icon.variables Previously that wasn't really possible, as the default theme overrides were always included, so even if your custom theme only needed a handful of icons you always got the whole set anyway. I did the same for emoji and flag already. The related script for self creation is adjusted in fomantic/create-fomantic-icons#184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change switches from hardcoded icon selectors in icon.overrides to LESS maps in icon.variables so they are easily changeable in a different theme
The previously extra handling of the "500px" class is not needed (in this script) anymore as it would break the LESS map generation and the conversion to "\35 00px" is now done in FUIs 2.9.0 icon.less file itself.