-
-
Notifications
You must be signed in to change notification settings - Fork 338
feat(lint): adjust LESS whitespaces to match prettier format #2612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(@(?:\w|-)+: )'([^"']*)'(;$)
(?<=\S) {2,}
Let's land these few CS changes now, PR #2611 needs some Prettier tool fixes, so PR #2611 cannot be finished soon. And good news! With this PR, the era of 10k LOC changed daily is done. For JS and LESS. Thank you @lubber-de ❤️ |
#([0-9a-f])\1([0-9a-f])\2([0-9a-f])\3
To verify this PR I run build before all changes and after. Then I run Prettier on both data (Prettier seems quite safe in sense of corrupting AST or comments). There are only a few changes in will selectors with removed space before I have also double checked all |
No, those would have a different meaning. the space indicates a child node, and without the space it indicates the exact node Damn, this is something that has been removed by the whitespace changes, which i did not recognize.... This has to be reverted to the state it was in 2.9.0 |
The wrong removement was done by fc431e8 |
I marked this PR as a draft and will take care of it. |
The change of removed space before pseudo classes is fixed/reverted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM
@mvorisek |
Did you installed all the packages that CI installs? It seems like the CSS is parsed without the less preprocessor. Maybe some config issue, you call the command from different pwd... |
Change template to double quotes again to match FUI linter as of fomantic/Fomantic-UI#2612
This PR fixes whitespaces unfixed/undetected in GH-2610 and major whitespace changes required for future Prettier integration.
Double quotes and lowecased hex colors are required by Prettier - prettier/prettier#5158 - and there is no config to change it. As long as we want to use Prettier, we must accept opinionated formatting by Prettier.