feat(lint): modernize/unify CSS but maintain IE11 compatibility #2594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lubber-de merged 15 commits into fomantic:develop from mvorisek:2_9_x_less_fixes

Dec 22, 2022

Contributor

mvorisek commented Dec 10, 2022 •

edited

Loading

Fix several stylelint stylelint-config-standard config advisories.

mvorisek force-pushed the 2_9_x_less_fixes branch 2 times, most recently from 30366e3 to 4154820 Compare

December 10, 2022 22:55

mvorisek commented

View reviewed changes

src/themes/resetcss/globals/reset.overrides Show resolved Hide resolved

mvorisek commented

View reviewed changes

src/definitions/elements/label.less Show resolved Hide resolved

mvorisek commented

View reviewed changes

src/definitions/modules/dropdown.less Show resolved Hide resolved

mvorisek commented

View reviewed changes

src/themes/default/elements/icon.variables Outdated Show resolved Hide resolved

mvorisek force-pushed the 2_9_x_less_fixes branch 2 times, most recently from 74411b2 to 62db616 Compare

December 14, 2022 16:37

mvorisek commented

View reviewed changes

src/themes/default/globals/reset.overrides Outdated Show resolved Hide resolved

mvorisek force-pushed the 2_9_x_less_fixes branch from 2be951e to fc29f94 Compare

December 14, 2022 19:17

mvorisek marked this pull request as ready for review

December 14, 2022 19:39

auto-assign bot requested review from ColinFrick, exoego, y0hami, ko2in, lubber-de and prudho

December 14, 2022 19:39

lubber-de reviewed

View reviewed changes

.stylelintrc.js Outdated Show resolved Hide resolved

lubber-de reviewed

View reviewed changes

src/themes/github/modules/dropdown.overrides Outdated Show resolved Hide resolved

lubber-de reviewed

View reviewed changes

src/themes/github/modules/dropdown.overrides Outdated Show resolved Hide resolved

lubber-de reviewed

View reviewed changes

src/themes/default/modules/dropdown.overrides Outdated Show resolved Hide resolved

lubber-de reviewed

View reviewed changes

src/themes/default/modules/dropdown.overrides Outdated Show resolved Hide resolved

mvorisek marked this pull request as draft

December 14, 2022 21:18

mvorisek mentioned this pull request

feat(lint): unify LESS files whitespaces and string quotes #2610

Merged

lubber-de pushed a commit that referenced this pull request


          feat(lint): unify LESS files whitespaces and string quotes

fc431e8

This PR is part of GH-2594 but separated to integrate many whitespace changes (and other non functional changes) separately.

mvorisek force-pushed the 2_9_x_less_fixes branch 5 times, most recently from e10492f to b6a38e5 Compare

December 16, 2022 19:36

mvorisek added 2 commits

December 21, 2022 23:02


          fix declaration-block-no-shorthand-property-overrides manually

5e7fbde


          strictly autofix declaration-block-no-duplicate-properties

749d981

mvorisek force-pushed the 2_9_x_less_fixes branch 2 times, most recently from a81fc2c to e8606ce Compare

December 21, 2022 22:23

mvorisek commented

View reviewed changes

src/themes/default/elements/segment.variables Show resolved Hide resolved


          fix more shorthand-property-no-redundant-values manually

b2d85ca

mvorisek force-pushed the 2_9_x_less_fixes branch from e8606ce to b2d85ca Compare

December 21, 2022 22:32


          fix font-family-no-duplicate-names manually

b2a6a4e

mvorisek force-pushed the 2_9_x_less_fixes branch from d4cd516 to c94eb5d Compare

December 21, 2022 23:09

mvorisek commented

View reviewed changes

src/themes/amazon/elements/button.overrides Outdated Show resolved Hide resolved

mvorisek added 3 commits

December 22, 2022 00:51


          fix (wrong) function-linear-gradient-no-nonstandard-direction manually

e3b281b


          fix declaration-block-no-redundant-longhand-properties manually


          ignore font-family-no-missing-generic-family-keyword

2e306d3

mvorisek force-pushed the 2_9_x_less_fixes branch from 2876aae to 2e306d3 Compare

December 21, 2022 23:51

mvorisek added 5 commits

December 22, 2022 00:57


          fix value-no-vendor-prefix manually

afe1132


          empty variable block is ok

9a2241a


          ignore selector-no-vendor-prefix for now

bfa3fb1


          ignore keyframes-name-pattern

62b3a73


          fix selector-class-pattern manually

238d9b5

mvorisek commented

View reviewed changes

src/themes/material/elements/icon.overrides Show resolved Hide resolved

mvorisek marked this pull request as ready for review

December 22, 2022 01:02


          Merge remote-tracking branch 'fomantic/develop'

cfcf4a1

lubber-de reviewed

View reviewed changes

src/themes/material/elements/button.variables Outdated Show resolved Hide resolved


          fix wrong fix

1e7ff35

lubber-de approved these changes

View reviewed changes

Member

lubber-de left a comment

LGTM

lubber-de changed the title ~~Modernize/unify CSS but maintain IE11 compatibility~~ feat(lint): modernize/unify CSS but maintain IE11 compatibility

lubber-de merged commit 6e2fa0f into fomantic:develop

mvorisek deleted the 2_9_x_less_fixes branch

December 22, 2022 16:32

lubber-de added the type/lint label

lubber-de added this to the 2.9.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lubber-de lubber-de approved these changes

ColinFrick Awaiting requested review from ColinFrick

exoego Awaiting requested review from exoego

y0hami Awaiting requested review from y0hami

ko2in Awaiting requested review from ko2in

prudho Awaiting requested review from prudho

Labels