Skip to content

fix(chore): eol of text files CRLF to LF #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2022
Merged

fix(chore): eol of text files CRLF to LF #2362

merged 3 commits into from
May 1, 2022

Conversation

mvorisek
Copy link
Contributor

pure CS fix

lubber-de
lubber-de reviewed Apr 30, 2022
View reviewed changes
lubber-de
lubber-de requested changes Apr 30, 2022
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont change the files inside the dist-folder.
That folder is being generated upon release.
Adjust the relevant less/overrides/variables file instead

@mvorisek mvorisek force-pushed the fix_eol_of_text_files branch from 3dbd89b to 6188232 Compare April 30, 2022 23:03
@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Apr 30, 2022
@lubber-de lubber-de added this to the 2.9.x milestone Apr 30, 2022
@mvorisek
Copy link
Contributor Author

Please dont change the files inside the dist-folder. That folder is being generated upon release. Adjust the relevant less/overrides/variables file instead

Fixed.

git add . -N && git diff --exit-code should be added to CI after compilation so commited files are verified if they are in-sync.

lubber-de
lubber-de requested changes May 1, 2022
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the files from the PR which purely changed the whole Line Separator. (See comments)
I am fine with all the other changes which only add a new line at the end of each file.

lubber-de
lubber-de approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after all :) Thanks for your patience

@lubber-de lubber-de changed the title Fix EOL of text files fix(chore): eol of text files CRLF to LF May 1, 2022
@lubber-de lubber-de merged commit b3c0489 into fomantic:develop May 1, 2022
@mvorisek mvorisek deleted the fix_eol_of_text_files branch May 1, 2022 19:53
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label May 1, 2022
@lubber-de lubber-de modified the milestones: 2.9.x, 2.9.0 May 1, 2022
@mvorisek mvorisek mentioned this pull request Dec 11, 2022
Merged
lubber-de pushed a commit that referenced this pull request Dec 11, 2022
@mvorisek
feat(lint): enforce LF line break in all JS and LESS files
6a42d01 
Assert GH-2362 and reject any CRLF present by CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@exoego exoego Awaiting requested review from exoego

@y0hami y0hami Awaiting requested review from y0hami

@ko2in ko2in Awaiting requested review from ko2in

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @lubber-de