feat(api): dont convert array response to object by default #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
lubber-de
requested review from
exoego,
ko2in,
ColinFrick,
prudho and
y0hami
This was referenced Feb 10, 2022
|
Docs added by fomantic/Fomantic-UI-Docs#329 |
lubber-de
added
the
state/has-docs
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems a more common case people are sending JSON array instead of JSON objects for their api response.
We already supported that since 2.7.0 #294 by the
rawResponsesetting, but people have to actively enable it.This PR changes the default value so json arrays are not converted to objects anymore by default.
I am still against always forcing json arrays no to be converted, because it is a valid conversion by
$.extendand probably still needed for some projects.Closes
#2220