Skip to content

fix(calendar): arrow keys on endCalendar when startCal has future month #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Jun 29, 2021

Description

Selecting a future month on a startCalendar didn't allow to use arrows on the endCalendar, since it was not refreshed before showing it.

Testcase

See #1851

Screenshot (if possible)

Broken:
Broken

Fixed:
Fixed

Closes

#1851

Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de changed the title [Calendar] arrow keys can now be used on endCalendar after setting a future month in the startCalendar fix(calendar): arrow keys on endCalendar when startCal has future month Jul 2, 2021
@lubber-de lubber-de merged commit 0f8087d into fomantic:develop Jul 2, 2021
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jul 2, 2021
@prudho prudho deleted the fix-1851 branch July 3, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[calendar] month cannot be changes using arrows using start/end calendars on endCalendar after selecting a future month on startCalendar
2 participants