fix(modal): correct undetached positioning when large modal is used #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
prudho
approved these changes
Oct 18, 2019
y0hami
removed
the
state/awaiting-reviews
y0hami
changed the title
lubber-de
added a commit
that referenced
this pull request
Feb 16, 2020
…with detachable false This PR gives full control over the useFlex setting again. Some combinations are not working for correct positioning, which was basically fixed by #1079 and #1096 However, the fixes ignored a possible explicit given useFlex:true and always assumes auto instead (which makes sure the positioning will work all the time) As it turned out here there are some usecases, where people need the explicit setting of useFlex:true, i reverted the logic for the can.useFlex method but added some debug warnings instead when unsupported combinations occur, because the positioning for useFlex:true will not work when: - IE11 is used - detachable:false is used As the default of useFlex is auto, existing code should basically work as before without any visual issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the fix by @prudho and corrects positioning calculation when
detachable: falsewas used together with large modals.This now works in any possible combination: detachable true/false, useFlex: true/false, top aligned, bottom aligned
Testcase
http://jsfiddle.net/5er1f3va/2/
Closes
#1079
#1138
Semantic-Org/Semantic-UI#4676