Skip to content

[Table] td cells in header are unstyled #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AllanJard opened this issue Apr 22, 2025 · 1 comment
Open

[Table] td cells in header are unstyled #3250

AllanJard opened this issue Apr 22, 2025 · 1 comment
Labels
state/awaiting-investigation Anything which needs more investigation type/bug Any issue which is a bug or PR which fixes a bug

Comments

@AllanJard
Copy link

Bug Report

It is valid to have td as well as th cells in a table header, and this is reasonably common in cases where there are multiple rows. The Fomantic code will style th cells in the header with padding, color, etc, but td cells are not.

This is due to the selector .ui.table > thead > tr > th in table.less.

It is worth noting that cells in the footer do not have this issue due to the following selector already being used:

.ui.table > tfoot > tr > th,
.ui.table > tfoot > tr > td {

I would actually propose for both that .ui.table > thead > tr > * be used (and similar for tfoot) since only th and td are valid.

Steps to reproduce

  1. https://jsfiddle.net/87jtmac0/
  2. Note that the cells in the second row of the header do not have any padding.

Expected result

The td and th cells in the header should have similar styling. Possibly you might want the font-weight to be reduced for td?

Actual result

There is no padding or other relevant styles applied to the td cells in the header.

Testcase

https://jsfiddle.net/87jtmac0/

Screenshot (if possible)

Image

Version

2.9.4. Current release at time of writing.

@AllanJard AllanJard added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Apr 22, 2025
@AllanJard
Copy link
Author

Just realised that the celled variant has the same issue in that the cells of the td cells don't have border-left, but th cells do: https://jsfiddle.net/4f3j18s0/ .

Image.

That's coming from here.

I reckon it could be simplified to be:

        .ui.structured.celled.table > tr > th,
        .ui.structured.celled.table > tr > td,
        .ui.structured.celled.table > thead > tr > *,
        .ui.structured.celled.table > tbody > tr > *,
        .ui.structured.celled.table > tfoot > tr > * {

Same with basic and perhaps some of the others.

AllanJard added a commit to DataTables/DataTablesSrc that referenced this issue Apr 22, 2025
AllanJard pushed a commit to DataTables/Dist-DataTables that referenced this issue Apr 22, 2025
…for `thead > tr > td` cells being unstyled

Logged at fomantic/Fomantic-UI#3250

Sync to source repo @bf5265bbda785f173239a915abcf828875cbbb6e
AllanJard pushed a commit to DataTables/Dist-DataTables-DataTables that referenced this issue Apr 22, 2025
…for `thead > tr > td` cells being unstyled

Logged at fomantic/Fomantic-UI#3250

Sync to source repo @bf5265bbda785f173239a915abcf828875cbbb6e
AllanJard pushed a commit to DataTables/Dist-DataTables-Bootstrap that referenced this issue Apr 22, 2025
…for `thead > tr > td` cells being unstyled

Logged at fomantic/Fomantic-UI#3250

Sync to source repo @bf5265bbda785f173239a915abcf828875cbbb6e
AllanJard pushed a commit to DataTables/Dist-DataTables-Foundation that referenced this issue Apr 22, 2025
…for `thead > tr > td` cells being unstyled

Logged at fomantic/Fomantic-UI#3250

Sync to source repo @bf5265bbda785f173239a915abcf828875cbbb6e
AllanJard pushed a commit to DataTables/Dist-DataTables-jQueryUI that referenced this issue Apr 22, 2025
…for `thead > tr > td` cells being unstyled

Logged at fomantic/Fomantic-UI#3250

Sync to source repo @bf5265bbda785f173239a915abcf828875cbbb6e
AllanJard pushed a commit to DataTables/Dist-DataTables-SemanticUI that referenced this issue Apr 22, 2025
…for `thead > tr > td` cells being unstyled

Logged at fomantic/Fomantic-UI#3250

Sync to source repo @bf5265bbda785f173239a915abcf828875cbbb6e
AllanJard pushed a commit to DataTables/Dist-DataTables-Bootstrap4 that referenced this issue Apr 22, 2025
…for `thead > tr > td` cells being unstyled

Logged at fomantic/Fomantic-UI#3250

Sync to source repo @bf5265bbda785f173239a915abcf828875cbbb6e
AllanJard pushed a commit to DataTables/Dist-DataTables-Bootstrap5 that referenced this issue Apr 22, 2025
…for `thead > tr > td` cells being unstyled

Logged at fomantic/Fomantic-UI#3250

Sync to source repo @bf5265bbda785f173239a915abcf828875cbbb6e
AllanJard pushed a commit to DataTables/Dist-DataTables-Bulma that referenced this issue Apr 22, 2025
…for `thead > tr > td` cells being unstyled

Logged at fomantic/Fomantic-UI#3250

Sync to source repo @bf5265bbda785f173239a915abcf828875cbbb6e
@lubber-de lubber-de removed the state/awaiting-triage Any issues or pull requests which haven't yet been triaged label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state/awaiting-investigation Anything which needs more investigation type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

2 participants