Allow activation element in shadow DOM to be auto-focused after trap is deactivated #1485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of related to #1072 / #1068
I noticed that support for shadow DOM focusing was added for custom elements within focus traps, but not for custom activation elements outside of focus traps.
This PR adds support for focusing on custom activation elements within the default deactivation behavior of the focus trap.
I tried writing Cypress tests for this change, but it doesn't seem to like custom elements and can't seem to focus on them.
PR Checklist
Please leave this checklist in your PR.
npm run demo-bundle
in your branch and include the/docs/demo-bundle.js
file that gets generated in your PR).// TEST MANUALLY
comments here) that can't be fully tested in Cypress have been manually verified.typeof document/window !== 'undefined'
before using it in code that gets executed on load.npm run changeset
locally to add one, and follow the prompts).