Skip to content

allow composer-installers version 2 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

saschanos
Copy link

Fixes #22

@domtra
Copy link
Member

domtra commented Feb 15, 2022

@saschanos Thanks a lot for this pull request.
Although we are using composer 2 already with the current version, making this compatible with composer/installers 2.0 is great.

As you can see, the travis build is failing, unfortunately. This should not be the case, as you specifically added "~1.0|~2.0" as a version requirement. (Btw. I think this is old syntax and ~1.0 || ~2.0 should probably be preferred).
The reason it is failing is probably because the committed composer.lock file requires composer/installers 2.0 and this is not compatible with older PHP versions.

Do you have an idea how to fix this? In the CI, we could delete the composer.lock before installing but i do not know if this will cause stability issues. Or we could commit 2 lock files that we switch depending on the PHP version in the CI. Unfortunately, I did not find an elegant, or actually any, solution anywhere. So if you have an idea, I would appreciate it. Otherwise I will just pick one if the two described solutions.

@saschanos
Copy link
Author

@domtra, thank you for your feedback :).

What's the reason for maintaining this package for php versions <= 7.1?

These are already out of support and should not be used by any php developer anymore (see: https://www.php.net/supported-versions.php). A lot of other libraries already dropped support for these versions. Would this be an option? We then should also add php 8.0 / php 8.1 to travis CI :).

@saschanos
Copy link
Author

@domtra, would be great to get a short reply here :)

@saschanos
Copy link
Author

@domtra, would be great to get some feedback here :)

@domtra
Copy link
Member

domtra commented Dec 18, 2023

@saschanos , i took your pr, adjusted it a bit and added some more code for ci, etc. thanks for your contribution again.

@domtra domtra closed this Dec 18, 2023
@domtra
Copy link
Member

domtra commented Dec 18, 2023

see #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow usage with composer/installers >=2.0
2 participants