[RFC-0010] Add provider audience to cache key and decouple packages #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuscscp
force-pushed
the
auth-audience-cache-key
branch
from
e2be6b8 to
1bda12b
Compare
57 tasks
matheuscscp
force-pushed
the
auth-audience-cache-key
branch
from
1bda12b to
6a42f84
Compare
stealthybox
approved these changes
May 19, 2025
matheuscscp
force-pushed
the
auth-audience-cache-key
branch
from
6a42f84 to
61878a4
Compare
matheuscscp
requested review from
stefanprodan,
aryan9600 and
hiddeco
as code owners
matheuscscp
changed the title
Signed-off-by: Matheus Pimenta <[email protected]>
matheuscscp
force-pushed
the
auth-audience-cache-key
branch
from
61878a4 to
82fd687
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: fluxcd/flux2#5022
After #925 the provider audience is no longer unique per provider, hence it needs to be part of the token cache key.
We are also decoupling the
authpackage from theoci,gitandgit/gogitpackages, which makes it much easier to release changes inauthand also avoids forcing these dependants from including loads of indirect dependencies that are extremely unneeded.