Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm: Add option to configure honorLabels for serviceMonitor #1442

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Helm: Add option to configure honorLabels for serviceMonitor #1442

merged 1 commit into from
Aug 28, 2023

Conversation

hsolberg
Copy link
Contributor

This change adds the possibility to enable honorLabels for serviceMonitor as it's by default set to false in the template.

Summary of honorLabels from the Prometheus documentation for reference.

If honor_labels is set to "true", label conflicts are resolved by keeping label values from the scraped data and ignoring the conflicting server-side labels.

If honor_labels is set to "false", label conflicts are resolved by renaming conflicting labels in the scraped data to "exported_" (for example "exported_instance", "exported_job") and then attaching server-side labels.

@hsolberg hsolberg marked this pull request as ready for review June 16, 2023 08:50
@hsolberg hsolberg requested a review from stefanprodan as a code owner June 16, 2023 08:50
@stefanprodan stefanprodan merged commit a41a7bb into fluxcd:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsolberg @stefanprodan