Fix canary to primary label promotion #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1405 +/- ##
==========================================
+ Coverage 54.42% 54.47% +0.05%
==========================================
Files 84 84
Lines 10049 10047 -2
==========================================
+ Hits 5469 5473 +4
+ Misses 3925 3921 -4
+ Partials 655 653 -2 ☔ View full report in Codecov by Sentry. |
|
@stefanprodan and feedback on resolving the failed e2e test? Seems to be a versioning issue with k8s |
address issue with all canary labels copied to primary on promote Signed-off-by: [email protected] <[email protected]> address review comments
aryan9600
approved these changes
Apr 10, 2023
aryan9600
changed the title
stefanprodan
changed the title
|
thank you @aryan9600 and @stefanprodan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address issue #1403 where all canary labels are copied to the primary on promote. This resulting in the following issues
include-label-prefixall labels would be copied overFix: #1403