Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ Support Drag and Select feature #175 #660

Merged
merged 35 commits into from
Feb 13, 2025

Conversation

WeiJun0507
Copy link
Contributor

@WeiJun0507 WeiJun0507 commented Nov 9, 2024

According to the previous PR #465, I have made a revamped version of the Drag and Select feature.

In this new pull request,

  1. Drag select logic has been moved into the Provider class to separate the UI layer and the Logic layer.
  2. Support Edge auto-scrolling using EdgeDraggingAutoScroller.
  3. Better position calculation to enhance the drag performance.

Additional

Fixes #674

@WeiJun0507
Copy link
Contributor Author

I have updated the code upon the above suggestion. Please re-review this PR again

@AlexV525
Copy link
Member

AlexV525 commented Dec 3, 2024

Now we have the AssetGridDragSelectionCoordinator that takes care of all calculations. The feature now supports selecting assets through long press, horizontal drag, and pan gestures. Anyone who is watching this, please feel free to give feedback!

@WeiJun0507
Copy link
Contributor Author

I am currently taking sick leave, and will endeavor to review and provide feedback as soon as possible. Thank you very much for your hard work; I truly appreciate it.❤️

@AlexV525 AlexV525 force-pushed the drag_select_featue_v2 branch 2 times, most recently from 7dda347 to 3363b48 Compare February 13, 2025 06:42
@AlexV525 AlexV525 force-pushed the drag_select_featue_v2 branch from 3363b48 to e9d605c Compare February 13, 2025 06:50
# Conflicts:
#	.github/workflows/runnable.yml
@AlexV525 AlexV525 force-pushed the drag_select_featue_v2 branch 3 times, most recently from 74eacc7 to 2b71706 Compare February 13, 2025 07:39
@AlexV525 AlexV525 force-pushed the drag_select_featue_v2 branch from 2b71706 to 1d81f38 Compare February 13, 2025 07:50
@AlexV525 AlexV525 linked an issue Feb 13, 2025 that may be closed by this pull request
@AlexV525 AlexV525 force-pushed the drag_select_featue_v2 branch from a1908f9 to 1608e6d Compare February 13, 2025 13:19
@AlexV525 AlexV525 merged commit 14de79e into fluttercandies:main Feb 13, 2025
7 checks passed
@AlexV525
Copy link
Member

@all-contributors Add @WeiJun0507 for business, code, ideas.

Copy link
Contributor

@AlexV525

I've put up a pull request to add @WeiJun0507! 🎉

AlexV525 pushed a commit that referenced this pull request Feb 13, 2025
…677)

Adds @WeiJun0507 as a contributor for business, code, ideas.

This was requested by AlexV525 [in this
comment](#660 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 选择图片列表显示不全 [Feature] Support selecting assets by drag operation
2 participants