-
Notifications
You must be signed in to change notification settings - Fork 6k
fix: Problem with Japanease IME on macOS #57286
fix: Problem with Japanease IME on macOS #57286
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
engine repo have been merged to flutter repo |
@@ -742,6 +742,18 @@ - (void)insertText:(id)string replacementRange:(NSRange)range { | |||
|
|||
_activeModel->SetSelection(flutter::TextRange(base, extent)); | |||
} | |||
else if (_activeModel->composing() && !(_activeModel->composing_range() == _activeModel->selection())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Please wrap this up to the previous line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks good -- please add a test to:
https://github.com/flutter/flutter/blob/master/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterTextInputPluginTest.mm
@cbracken could you follow up to get this moved to flutter/flutter? |
Monorepo Migration Completed
The
This is a canned message |
Pre-launch Checklist
///
).CC @cbenhagen