This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Embedder] Refactor how semantic updates are mapped #44553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
Aug 9, 2023
| // Create a callback to notify the embedder of semantic updates | ||
| // using the new embedder callback 'update_semantics_callback2'. | ||
| flutter::PlatformViewEmbedder::UpdateSemanticsCallback | ||
| CreateNewEmbedderSemanticsUpdateCallback2( |
There was a problem hiding this comment.
This was renamed to CreateEmbedderSemanticsUpdateCallbackV3 and moved down to below CreateEmbedderSemanticsUpdateCallbackV2.
loic-sharma
commented
Aug 9, 2023
| // Create a callback to notify the embedder of semantic updates | ||
| // using the deprecated embedder callback 'update_semantics_callback'. | ||
| flutter::PlatformViewEmbedder::UpdateSemanticsCallback | ||
| CreateNewEmbedderSemanticsUpdateCallback( |
There was a problem hiding this comment.
This was renamed to CreateEmbedderSemanticsUpdateCallbackV2 and moved down to below CreateEmbedderSemanticsUpdateCallbackV1.
8 tasks
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 11, 2023
…132407) flutter/engine@622ded9...832e780 2023-08-11 [email protected] Allow macOS plugins to register as app delegates (flutter/engine#44587) 2023-08-11 [email protected] Roll Skia from 68ea92de8f29 to 7dd695d828cf (1 revision) (flutter/engine#44643) 2023-08-11 [email protected] Roll Dart SDK from 83f96a990792 to ade04f1beb2c (1 revision) (flutter/engine#44642) 2023-08-11 [email protected] Roll Skia from fa30af9c2b80 to 68ea92de8f29 (2 revisions) (flutter/engine#44641) 2023-08-11 [email protected] [Impeller] Added benchmark for advanced blend. (flutter/engine#44450) 2023-08-11 [email protected] [Embedder] Refactor how semantic updates are mapped (flutter/engine#44553) 2023-08-11 [email protected] Roll Skia from cfb9844091fa to fa30af9c2b80 (1 revision) (flutter/engine#44639) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
Flutter's `SemanticNode`s use [`StringAttribute`](https://api.flutter.dev/flutter/dart-ui/StringAttribute-class.html)s to provide additional information on text values for assistive technologies. This exposes the string attributes on the embedder API so that embedders can apply string attributes to their semantics trees. Addresses flutter/flutter#119970 Part of flutter/flutter#98948 Previous pull request: #44553 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
This refactors how engine semantic updates are mapped to embedder semantic updates. There are no behavioral changes. Part of flutter/flutter#119970, flutter/flutter#98948 Next PR: flutter#44616 ## Background For flutter/flutter#119970, we will need to update the embedder API to add string attributes to semantic nodes' text values. There are multiple kinds of string attributes, and each text value can have multiple string attributes. This requires gnarly mapping code that's best kept out of `embedder.cc`. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Flutter's `SemanticNode`s use [`StringAttribute`](https://api.flutter.dev/flutter/dart-ui/StringAttribute-class.html)s to provide additional information on text values for assistive technologies. This exposes the string attributes on the embedder API so that embedders can apply string attributes to their semantics trees. Addresses flutter/flutter#119970 Part of flutter/flutter#98948 Previous pull request: flutter#44553 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors how engine semantic updates are mapped to embedder semantic updates. There are no behavioral changes.
Part of flutter/flutter#119970, flutter/flutter#98948
Next pull request: #44616
Background
For flutter/flutter#119970, we will need to update the embedder API to add string attributes to semantic nodes' text values. There are multiple kinds of string attributes, and each text value can have multiple string attributes. This requires gnarly mapping code that's best kept out of
embedder.cc.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.