Skip to content

Remove completed flag migrations for CiYaml. #4762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025

Conversation

matanlurey
Copy link
Contributor

Closes flutter/flutter#169625.

Both:

  • onlyUseTipOfTreeTargetsExistenceToFilterTargets
  • targetEnabledBranchesOverridesTipOfTreeTargetExistence

... have been enabled for a few days without incident. Let's clean up the tech-debt.

@matanlurey matanlurey requested a review from jtmcdole June 4, 2025 00:38
Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol @ "John said I could"

Comment on lines +10 to +11
# TODO(matanlurey): These are inert in the latest builds and can be removed
# a few days after https://github.com/flutter/cocoon/pull/4762 is merged.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14 days if the "old images are removed after 14 days" rule is being followed.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App. label Jun 4, 2025
@auto-submit auto-submit bot merged commit 59f75f7 into flutter:main Jun 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tech-debt in .ci.yaml target-ToT filtering
2 participants