Delete the V2 experiment, add a TreeStatusPage.
#4761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmcdole
approved these changes
Jun 4, 2025
Comment on lines
+233
to
+237
| body: jsonEncode({ | ||
| 'repo': repo, | ||
| 'status': status.name, | ||
| if (reason != null) 'reason': reason, | ||
| }), |
There was a problem hiding this comment.
We don't want a shared JsonSerializable for this? TreeStatusChange has repo/status/reason.
There was a problem hiding this comment.
Mental TODO, yeah this should just be using TreeStatusChange.toJson().
|
|
||
| @JsonSerializable(checked: true) | ||
| @immutable | ||
| final class TreeStatusChange extends Model { |
There was a problem hiding this comment.
Same as the firebase TreeStatusChange?
There was a problem hiding this comment.
Yeah that's intentional - the frontend uses this as well.
matanlurey
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the UI-facing bits of flutter/flutter#74529.
This is "hidden" behind the page URL not being part of the navigation.
I ended up EOL'ing the
V2experiment, it's too much work to adopt a new navigation model at the moment. Instead, I'm pulling out a reusableCocoonScaffoldwhich allows new pages to be added without much work. Here's an example if you're too lazy to run this locally: